Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Neuron] Upgrade neuron to 2.20.2 #11016

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[Neuron] Upgrade neuron to 2.20.2 #11016

merged 1 commit into from
Dec 9, 2024

Conversation

xendo
Copy link
Contributor

@xendo xendo commented Dec 9, 2024 •
edited by github-actions bot
Loading

This change also fixed loading Neuron models. Neuron uses old pytorch,
before the change I was getting

TypeError: infer_schema() takes 1 positional argument but 2 were given

which was caused by custom_op direct registration. I'm disabling that if custom_op is not available.

I tested this using

vllm serve openlm-research/open_llama_3b_v2 --tensor-parallel-size 2 --device neuron --max-num-seqs 8 --max-model-len 1024

FIX #10932

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 9, 2024
Upgrade neuron to 2.20.2
56457d5 
This change also fixed loading Neuron models. Neuron uses old pytorch,
 before the change I was getting

TypeError: infer_schema() takes 1 positional argument but 2 were given

which was caused by custom_op direct registration. I'm disabling that
if custom_op is not available.

Signed-off-by: Jerzy Zagorski <[email protected]>
@xendo xendo changed the title Upgrade neuron to 2.20.2 [Neuron] Upgrade neuron to 2.20.2 Dec 9, 2024
@xendo xendo marked this pull request as ready for review December 9, 2024 13:09
@xendo xendo mentioned this pull request Dec 9, 2024
Closed
1 task
youkaichao
youkaichao approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! cc @liangfu

@youkaichao youkaichao merged commit 9c6459e into vllm-project:main Dec 9, 2024
20 of 24 checks passed
@xendo xendo deleted the neuron-2.20.2 branch December 10, 2024 07:48
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@xendo
[Neuron] Upgrade neuron to 2.20.2 (vllm-project#11016)
b310802 
Signed-off-by: Jerzy Zagorski <[email protected]>
Co-authored-by: Jerzy Zagorski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chongmni-aws chongmni-aws chongmni-aws approved these changes

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
ci/build
Projects
None yet
Milestone
No milestone
3 participants
@xendo @youkaichao @chongmni-aws